Fix sphinx multimethod customization (#1120 #1121 #1122) #1123
+41
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 40 40
Lines 9672 9672
Branches 1280 1280
=======================================
Hits 9317 9317
Misses 210 210
Partials 145 145 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
It should be fixed now. See https://cadquery--1123.org.readthedocs.build/en/1123/classreference.html |
jmwright
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
@lorenzncode Thanks for putting this together. Looks good to me.
@adam-urbanczyk Feel free to merge if it looks good to you.
adam-urbanczyk
approved these changes
Aug 6, 2022
|
LGTM, thanks @lorenzncode ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.